Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send one sample event, response per label set in the configured duration #5298

Open
wants to merge 4 commits into
base: feat.reports-bactching
Choose a base branch
from

Conversation

vamsikrishnakandi
Copy link
Contributor

@vamsikrishnakandi vamsikrishnakandi commented Nov 14, 2024

Description

Send one sample event or response per LabelSet to reporting within the configured duration.

  • Generate a hash for each report and store it in badger db.
  • If the hash is already present in the db, do not resend the sample event or response. If the hash is not present, send the sample event/response.
  • The hash stored in the db expires after the configured TTL.

Linear Ticket

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 66.45570% with 53 lines in your changes missing coverage. Please review.

Project coverage is 73.29%. Comparing base (22a89e8) to head (bc0acdd).

Files with missing lines Patch % Lines
enterprise/reporting/reporting.go 16.66% 27 Missing and 3 partials ⚠️
enterprise/reporting/event_sampler.go 75.26% 19 Missing and 4 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat.reports-bactching    #5298      +/-   ##
==========================================================
+ Coverage                   73.19%   73.29%   +0.09%     
==========================================================
  Files                         424      426       +2     
  Lines                       59949    60107     +158     
==========================================================
+ Hits                        43879    44054     +175     
+ Misses                      13606    13591      -15     
+ Partials                     2464     2462       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vamsikrishnakandi vamsikrishnakandi marked this pull request as ready for review November 15, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant