fix: use sum64 to avoid checkptr race bug #2645
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix addresses a panic when running with
--race
flag:The culprit is the following line, which is called
murmur3.Sum64
The usage of unsafe is being condemned in this issue and we should probably consider changing the library all together
Does it make sense to use int64 ?
Yes, both the pglock library and postgress supports this:
https://www.postgresql.org/docs/9.1/functions-admin.html
It also works with negative numbers
To avoid code like this being added in the future, I am considering enabling
--race
flag for all the tests, hoping the times are not going up.Notion Ticket
https://www.notion.so/rudderstacks/murmur-race-fix-25aa4f37c58047faa1ff7baed24c0960
Security