Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PrependTrueOptionOnBeforeDestroy cop #922

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SHinGo-Koba
Copy link

@SHinGo-Koba SHinGo-Koba commented Jan 23, 2023

There are possibilities that dependent: :destroy causes unexpectedly deletion of associated records even if you set before_destroy callbacks which are expected to be triggered before dependent: :destroy is invoked.

This can occur because dependent: :destroy is one of callbacks as well as before_destroy, so they are run in the order they are defined.
Related Issue was reported and rails guide refers to this operation.

Unexpected deletion of records could be an incident, so I would be happy to prevent it from happening in advance by rubocop-rails.

Adding prepend: true option on before_destroy is known as one of solutions of it.
So I tried to apply this solution as a new rule.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@SHinGo-Koba SHinGo-Koba force-pushed the prepend_true_option_on_before_destroy branch 3 times, most recently from 5604af7 to d470791 Compare January 23, 2023 14:26
Prevents unexpected deletion of associated records
@SHinGo-Koba SHinGo-Koba force-pushed the prepend_true_option_on_before_destroy branch from d470791 to 55e006d Compare January 23, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant