Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1066] Fix an error for Rails/FilePath #1068

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

koic
Copy link
Member

@koic koic commented Aug 14, 2023

Fixes #1066.

This PR fixes an error for Rails/FilePath when string interpolated Rails.root is followed by a message starting with ..


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Fixes rubocop#1066.

This PR fixes an error for `Rails/FilePath`
when string interpolated `Rails.root` is followed by a message starting with `.`.
@koic koic merged commit 3bc0e2d into rubocop:master Aug 16, 2023
4 checks passed
@koic koic deleted the fix_an_error_for_rails_file_path branch August 16, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error occurred while Rails/FilePath cop was inspecting String interpolation containing Rails.root
1 participant