[Fix #1062] Correct rake tasks with arguments #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Aug 10, 2023
| end | ||
| end | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def correct_task_arguments_dependency(task_method) | ||
| "#{task_arguments(task_method).source} => [:environment]" |
There was a problem hiding this comment.
Can you tweak the autocorrection code? It seems to work with symbol instead of array.
Suggested change
| "#{task_arguments(task_method).source} => [:environment]" | |
| "#{task_arguments(task_method).source} => :environment" |
koic
reviewed
Aug 10, 2023
Comment on lines
49
to
50
| args_deps_hash = correct_task_arguments_dependency(task_method) | ||
| corrector.replace(task_method.arguments[1], args_deps_hash) |
There was a problem hiding this comment.
Can you refactor?
Suggested change
| args_deps_hash = correct_task_arguments_dependency(task_method) | |
| corrector.replace(task_method.arguments[1], args_deps_hash) | |
| new_task_dependency = correct_task_arguments_dependency(task_method) | |
| corrector.replace(task_arguments(task_method), new_task_dependency) |
koic
reviewed
Aug 10, 2023
Comment on lines
52
to
54
| task_name = task_method.arguments[0] | ||
| task_dependency = correct_task_dependency(task_name) | ||
| corrector.replace(task_name, task_dependency) |
There was a problem hiding this comment.
Suggested change
| task_name = task_method.arguments[0] | |
| task_dependency = correct_task_dependency(task_name) | |
| corrector.replace(task_name, task_dependency) | |
| task_name = task_method.first_argument | |
| new_task_dependency = correct_task_dependency(task_name) | |
| corrector.replace(task_name, new_task_dependency) |
koic
reviewed
Aug 10, 2023
| RUBY | ||
|
|
||
| expect_correction(<<~RUBY) | ||
| task :foo, [:arg] => [:environment] do |
There was a problem hiding this comment.
Suggested change
| task :foo, [:arg] => [:environment] do | |
| task :foo, [:arg] => :environment do |
|
Looks good to me. Can you squash your commits into one? |
Account for rake tasks that accept arguments.
fastjames
force-pushed
the
rake_environment_autocorrect_args
branch
from
23149d7
to
dd17d2d
Compare
I was hoping that you would ask! I have squashed my fixes back into the original commit. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When auto-correcting rake tasks to include the
:environmentprerequisite, account for rake tasks that accept arguments.closes #1062
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.