Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make downloadFileWithId method private in final class #1441

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Make downloadFileWithId method private in final class #1441

wants to merge 5 commits into from
+1 −1

Conversation

panic08
Copy link

@panic08 panic08 commented Oct 8, 2024 •
edited
Loading

Since the DefaultAbilities class is final, it is unnecessary to mark the method as protected because the class cannot be inherited

By marking the method as private, it will match the class design and restrict access to the method only within the class

@panic08 panic08 changed the base branch from master to dev November 9, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panic08 @rubenlagus