Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component2 load #131

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Component2 load #131

wants to merge 6 commits into from

Conversation

veon82
Copy link
Contributor

@veon82 veon82 commented Nov 7, 2017

  • Introduces new option component2Load: allows export of a single component of a workspace in a new git repository

…ty workspace and add the specified component to it. getcomponentbaselineentriesfromstream(): if component2load is set append only the specified component to list
@veon82 veon82 closed this Nov 7, 2017
@veon82 veon82 reopened this Nov 7, 2017
configuration.py Outdated
@@ -45,6 +45,10 @@ def read(configname=None):
workdirectory = generalsection.get('Directory', os.getcwd())
streamname = shlex.quote(migrationsection['StreamToMigrate'].strip())
previousstreamname = migrationsection.get('PreviousStream', '').strip()

# new option
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this comment, it doesnt provide any value

@@ -22,6 +22,9 @@ StreamToMigrate = MyDevelopmentStream
# (eg. When Migrating Stream_Version2, Previous-Stream would be Stream_Version1
PreviousStream=

# Specify if you want to load a single component
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you elaborate what kind of value needs to be set here (is it componentname or component uuid or just true etc..)

And maybe a little bit more detailed explaination - what this option does

@WtfJoke
Copy link
Member

WtfJoke commented Nov 24, 2017

Check my comments on your changes. If you solve them, I'll merge the changes

@veon82
Copy link
Contributor Author

veon82 commented Dec 28, 2017

Let me know if the comment added on config.ini.sample is clear enough now.

@WtfJoke
Copy link
Member

WtfJoke commented Jan 14, 2018

Yeah, the comment is clear enough.

I need some more time (probably in some weeks) to review the pull requests. I currently dont have any rtc available for testing. Hope you understand

@veon82
Copy link
Contributor Author

veon82 commented Jan 15, 2018

No problem, take your time.

@WtfJoke WtfJoke mentioned this pull request Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants