Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added closed connection callback #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added closed connection callback #17

wants to merge 1 commit into from

Conversation

lashket
Copy link

@lashket lashket commented Apr 5, 2022

Added callback to be notified when Websocket is closed

@cryptpa
Copy link

cryptpa commented Apr 5, 2022

you are the man!!! What about closing the request stream connection.

@marinkobabic
Copy link

Why is this pull request still open?

@szymek-pindelski
Copy link

hello,
does this pull request have something to do with active stream subscriptions surviving RSocket.close() ?
My stream subscription does not seem to notice that rsocket has been closed, and I need to explicitly cancel it (in case you're wondering - I'm using websocket as transport layer)
I read somewhere that RSocket.close() is supposed to cancel any active subscriptions but it's clearly not the case with RSocket Dart implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lashket @cryptpa @marinkobabic @szymek-pindelski