Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUIDPermissionsCheck: chkstat to permctl rename #1294

Merged
merged 1 commit into from
Nov 6, 2024
Merged

SUIDPermissionsCheck: chkstat to permctl rename #1294

merged 1 commit into from
Nov 6, 2024

Conversation

danigm
Copy link
Member

@danigm danigm commented Nov 5, 2024

This patch checks for permctl or chkstat commands in the POSTIN, so it should be compatible with the new name and also the old one.

Fix #1292

Copy link

@FilippoBonazziSUSE FilippoBonazziSUSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass. Thanks for working on this btw

@danigm danigm merged commit 036a257 into opensuse Nov 6, 2024
13 checks passed
@DimStar77
Copy link
Contributor

this rpmlint change has made it into a Staging for openSUSE and I see crashes like this:

[  237s] RPMLINT report:
[  237s] ===============
[  239s] (none): E: fatal error while reading //home/abuild/rpmbuild/RPMS/x86_64/coreutils-9.5-7.3.x86_64.rpm: unterminated character set at position 33
[  239s] Traceback (most recent call last):
[  239s]   File "/opt/testing/bin/rpmlint.real", line 8, in <module>
[  239s]     sys.exit(lint())
[  239s]              ^^^^^^
[  239s]   File "./rpmlint/cli.py", line 184, in lint
[  239s]   File "./rpmlint/lint.py", line 123, in run
[  239s]   File "./rpmlint/lint.py", line 91, in _run
[  239s]   File "./rpmlint/lint.py", line 264, in validate_files
[  239s]   File "./rpmlint/lint.py", line 290, in validate_file
[  239s]   File "./rpmlint/lint.py", line 283, in validate_file
[  239s]   File "./rpmlint/lint.py", line 299, in run_checks
[  239s]   File "./rpmlint/checks/SUIDPermissionsCheck.py", line 186, in check
[  239s]   File "./rpmlint/checks/SUIDPermissionsCheck.py", line 63, in _check_post_scriptlets
[  239s]   File "./re/__init__.py", line 176, in search
[  239s]   File "./re/__init__.py", line 294, in _compile
[  239s]   File "./re/_compiler.py", line 745, in compile
[  239s]   File "./re/_parser.py", line 989, in parse
[  239s]   File "./re/_parser.py", line 464, in _parse_sub
[  239s]   File "./re/_parser.py", line 572, in _parse
[  239s] re.error: unterminated character set at position 33

e.g. on https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:N/coreutils/standard/x86_64

@danigm
Copy link
Member Author

danigm commented Nov 8, 2024

this rpmlint change has made it into a Staging for openSUSE and I see crashes like this:

[  237s] RPMLINT report:
[  237s] ===============
[  239s] (none): E: fatal error while reading //home/abuild/rpmbuild/RPMS/x86_64/coreutils-9.5-7.3.x86_64.rpm: unterminated character set at position 33
[  239s] Traceback (most recent call last):
[  239s]   File "/opt/testing/bin/rpmlint.real", line 8, in <module>
[  239s]     sys.exit(lint())
[  239s]              ^^^^^^
[  239s]   File "./rpmlint/cli.py", line 184, in lint
[  239s]   File "./rpmlint/lint.py", line 123, in run
[  239s]   File "./rpmlint/lint.py", line 91, in _run
[  239s]   File "./rpmlint/lint.py", line 264, in validate_files
[  239s]   File "./rpmlint/lint.py", line 290, in validate_file
[  239s]   File "./rpmlint/lint.py", line 283, in validate_file
[  239s]   File "./rpmlint/lint.py", line 299, in run_checks
[  239s]   File "./rpmlint/checks/SUIDPermissionsCheck.py", line 186, in check
[  239s]   File "./rpmlint/checks/SUIDPermissionsCheck.py", line 63, in _check_post_scriptlets
[  239s]   File "./re/__init__.py", line 176, in search
[  239s]   File "./re/__init__.py", line 294, in _compile
[  239s]   File "./re/_compiler.py", line 745, in compile
[  239s]   File "./re/_parser.py", line 989, in parse
[  239s]   File "./re/_parser.py", line 464, in _parse_sub
[  239s]   File "./re/_parser.py", line 572, in _parse
[  239s] re.error: unterminated character set at position 33

e.g. on https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:N/coreutils/standard/x86_64

Wops, I didn't escape the path for the regular expression. This PR should fix the issue: #1299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants