-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add flake8 extra plugins #1098
add flake8 extra plugins #1098
Conversation
These plugins are already used in opensuse distros
Looks like fedora rawhide doesn't like the quotes:
|
I will add an another commit with those edits. |
1c37026
to
f3a73e8
Compare
f3a73e8
to
227d527
Compare
Looks like the python3.12 in fedora rawhide is complaining about quotes in fstrings. This is related to the new syntactic formalization of f-string. To make this compatible between 3.12 and previous versions, we can just ignore the error just in these kind of lines. The other option is to move values to variables so there's no "quotes" in f-strings, and looks like this PR is following that option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now this change looks good to me.
This seems to be invalid code:
line 151 being: |
My bad, all these lines should be like |
Just created a new PR to fix the issue, I'll merge as soon as the CI pass: #1111 |
Fedora workflow runners are missing flake8's other plugins used in opensuse.
Added plugins:
python3-flake8-builtins
python3-flake8-quotes
And still
python3-flake8-bugbear
is missing. Which can be installed through pip if required. Please confirm on this if I can add a pip install command for the same as well.