Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When multi_progress_bar finishes print new line automatically #1805

Merged
merged 2 commits into from
Nov 1, 2024
Merged

When multi_progress_bar finishes print new line automatically #1805

merged 2 commits into from
Nov 1, 2024

Commits on Oct 29, 2024

  1. When multi_progress_bar finishes print new line automatically 

    The last line of `multi_progress_bar` can look like:
`[2/2] Total           100% |   0.0   B/s |  20.0   B |  00m00s`
or
`http://localhost:43223/api_3/rpmrepo 100% |  72.0 KiB/s | 295.0   B |  00m00s`
I don't think any client will ever want to append to that.

Instead of it needing to be printed by the client the
`multi_progress_bar` automatically ends with a new line.

This new line was missing on some places. For example in output of:
`dnf copr enable rpmsoftwaremanagement/dnf-nightly `
or
`dnf5 rq --repofrompath=test,https://www.not-available-repo.com/ --repo test --setopt=skip_if_unavailable=0`
There were also excessive new lines like in:
`dnf5 remove htop -y &> out`

Closes: rpm-software-management#1792
    @kontura
    kontura committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    9d1ec9d View commit details
    Browse the repository at this point in the history

  2. Add couple progress bar unit tests 

    Mostly to test new lines after `multi_progress_bar`.
    @kontura
    kontura committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    009ba99 View commit details
    Browse the repository at this point in the history