historydb: Prevent insertion of duplicate group packages #1798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a package is included in a comps group multiple times, dnf5
attempts to insert that package multiple times into the
comps_group_package table
of the transaction history database. However,the table enforces a unique constraint on the (group_id, name_id) tuple.
This results in terminating dnf5 process.
This patch modifies the CompsGroupPackageDbUtils::comps_group_packages_insert()
method to track which packages have already been inserted and skip
duplicates.
Here is an example of such group with duplicated packages from rpmfusion
repository (see the
libavcodec-freeworld
package):Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2263762
Test: rpm-software-management/ci-dnf-stack#1580