transaction_callbacks: Deprecate confusing alias #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisar
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Looks good. It preserves API and ABI.
The test failures are probably caused by toml11 (#1693).
I have only one request: Could you make the commit title more concrete? E.g. "transaction_callbacks: Deprecate libdnf5::rpm::TransactionItem alias". Those titles go into release notes.
Given that there is another TransactionItem class in libdnf5::transaction namespace, the alias libnf5::rpm::TransactionItem -> libdnf5::base::TransactionPackage is confusing and does not add any value to the user. This patch deprecates it and uses directly TransactionPackage in all places.
m-blaha
force-pushed
the
mblaha/callbacks-alias
branch
from
f48afbb
to
313a477
Compare
Thanks, changed. |
ppisar
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that there is another TransactionItem class in
libdnf5::transaction namespace, the alias libnf5::rpm::TransactionItem ->
libdnf5::base::TransactionPackage is confusing and does not add any
value to the user.
This patch deprecates it and uses directly TransactionPackage in all
places.