Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rosidl cli types with specs_set fix #831

Merged
merged 15 commits into from
Oct 30, 2024
Merged

Rosidl cli types with specs_set fix #831

merged 15 commits into from
Oct 30, 2024

Conversation

InvincibleRMC
Copy link
Contributor

@InvincibleRMC InvincibleRMC commented Oct 7, 2024 •
edited
Loading

Fixes problem found in #830. Adds a proper default of None to specs_set. A redo of #826.

@InvincibleRMC
init
a9db952 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
add type to fixture
2b60f34 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
remove import
bb3baef 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
add #type: ignore on yaml import
58d1ed1 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
move #
e736ff8 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Add ament_mypy dep
6559e5e 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Add missing py.typed file
853e394 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
fix entry_points
4fef19e 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Fix Unpack erros by removing kwargs
5017663 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
fix groups error
538dd04 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
remove unused import
5e59e26 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Use Union Tuple
cc29d8a 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Add missing specs_set default
0bfd8d3 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Merge branch 'rolling' into rosidl_cli-types
629e919
@Crola1702 Crola1702 mentioned this pull request Oct 7, 2024
Closed
fujitatomoya
fujitatomoya approved these changes Oct 7, 2024
View reviewed changes
Copy link

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

rosidl_cli/rosidl_cli/entry_points.py
Comment on lines +36 to +37
else:
specs_set = None
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the fix for the regression reported with osrf/buildfarm-tools#99, and this is the only difference from https://github.com/ros2/rosidl/pull/826/commits

@fujitatomoya
Copy link

Pulls: #831
Gist: https://gist.githubusercontent.com/fujitatomoya/ce94ef448780cc49f11d452b9a487972/raw/91a447ce7e711d4075449cc8c6321ad2be8d6132/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_cli
TEST args: --packages-above rosidl_cli
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14672

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@sloretz
Copy link
Contributor

sloretz commented Oct 29, 2024

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

update

✅ Branch has been successfully updated

@sloretz
Copy link
Contributor

sloretz commented Oct 29, 2024

Pulls: #831
Gist: https://gist.githubusercontent.com/sloretz/aff73674edff8eba0caa5b6443bf929b/raw/91a447ce7e711d4075449cc8c6321ad2be8d6132/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_cli
TEST args: --packages-above rosidl_cli
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14751

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

sloretz
sloretz approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@sloretz sloretz merged commit 4f5f80c into ros2:rolling Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@sloretz sloretz sloretz approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

@quarkytale quarkytale Awaiting requested review from quarkytale quarkytale is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@InvincibleRMC @fujitatomoya @sloretz