Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept custom allocator for LoanedMessage. #2672

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

accept custom allocator for LoanedMessage. #2672

wants to merge 1 commit into from

Conversation

fujitatomoya
Copy link
Collaborator

closes #2671

fujitatomoya
fujitatomoya commented Nov 13, 2024
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasmoore-torc could you review this?

@fujitatomoya fujitatomoya mentioned this pull request Nov 13, 2024
Open
@fujitatomoya
Copy link
Collaborator Author

Pulls: #2672
Gist: https://gist.githubusercontent.com/fujitatomoya/c94c33d5d9b178b7fdb3a880191237b7/raw/ae815ef620a2b5f805d36af338047dadb02555dd/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14815

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

thomasmoore-torc
thomasmoore-torc approved these changes Nov 14, 2024
View reviewed changes
Copy link

@thomasmoore-torc thomasmoore-torc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to make MessageAllocatorTraits and MessageAllocator public instead of private? I don't think it's necessary for this specific change, but it would make LoanedMessage be more consistent with other class definitions in rclcpp.

Also, would it be possible to back-port this change to jazzy and iron?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasmoore-torc thomasmoore-torc thomasmoore-torc approved these changes

@ivanpauno ivanpauno Awaiting requested review from ivanpauno ivanpauno is a code owner

@hidmic hidmic Awaiting requested review from hidmic hidmic is a code owner

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to use custom allocator with LoanedMessage
2 participants
@fujitatomoya @thomasmoore-torc