Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update control_msgs to use humble-devel branch for humble and newer #40799

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

tfoote
Copy link
Member

@tfoote tfoote commented Apr 23, 2024

@bmagyar @christophfroehlich

I was looking at a compliance process and found that ros-controls/control_msgs#114 wasn't available in the devel branch and saw that it was pointing all the way back to foxy. When there was a humble backport here: ros-controls/control_msgs#116

Based on this humble backport I'm assuming that humble is the appropriate development branch for humble and also iron, where rolling is on master.

I was looking at a compliance process and found that #114 wasn't available in the devel branch and saw that it was pointing all the way back to foxy.
@github-actions github-actions bot added humble Issue/PR is for the ROS 2 Humble distribution iron Issue/PR is for the ROS 2 Iron distribution labels Apr 23, 2024
@tfoote
Copy link
Member Author

tfoote commented Apr 23, 2024

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update!
I was wondering these days why the api docs on docs.ros.org are not present for humble/iron, but this could explain it. Is the docs job started automatically or can we trigger that?
https://build.ros2.org/job/Idoc__control_msgs__ubuntu_jammy_amd64/lastBuild/
https://build.ros2.org/job/Hdoc__control_msgs__ubuntu_jammy_amd64/

tfoote added a commit to tfoote/ros_interface_proto_builder that referenced this pull request Apr 24, 2024
@tfoote tfoote merged commit aae20f4 into master Apr 24, 2024
4 checks passed
@tfoote tfoote deleted the control_msgs_branch_update branch April 24, 2024 07:26
@tfoote
Copy link
Member Author

tfoote commented Apr 24, 2024

The doc job should reconfigure overnight with the new branch and then run on the next polling cycle detecting the content, which I think is every 3 days right now.

@christophfroehlich
Copy link
Contributor

great, thanks!

@bmagyar
Copy link
Contributor

bmagyar commented Apr 24, 2024

Perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
humble Issue/PR is for the ROS 2 Humble distribution iron Issue/PR is for the ROS 2 Iron distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants