Fix handling of multiple namespaced python packages in devel space #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are multiple packages to be installed below a common namespace, only the last one installed is found in devel space, because the path extension is always overwritten. This PR augments the existing __extended_path.
rhaschke
force-pushed
the
fix-namespace-pkgs
branch
from
47a8eba
to
9b2c06f
Compare
|
Hm. Unfortunately, this works only with catkin tools and merged devel space as well as with |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are multiple python packages to be installed below a common namespace, only the last one installed is found in devel space, because the path extension is always overwritten.
This PR augments the existing
__extended_pathinstead of overriding it.We need this feature for MoveIt, which has multiple python packages to be installed in the common namespace
moveit.