Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CMake policy CMP0135 #182

Closed
wants to merge 1 commit into from

Conversation

mintar
Copy link
Contributor

@mintar mintar commented Apr 26, 2024

This hopefully fixes the following error on ROS2 Rolling (Ubuntu 24.04):

The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is...

See https://build.ros2.org/job/Rdev__phidgets_drivers__ubuntu_noble_amd64/4/cmake/

This hopefully fixes the following error on ROS2 Rolling (Ubuntu 24.04):

    The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is...

See https://build.ros2.org/job/Rdev__phidgets_drivers__ubuntu_noble_amd64/4/cmake/
@mintar
Copy link
Contributor Author

mintar commented Apr 26, 2024

Never mind, I'm going to close this and leave the warning unfixed, because Ubuntu 22.04 (ROS2 Iron) has cmake 3.22, but CMP0135 was introduced in cmake 3.24. Therefore, we cannot merge this PR into the iron/humble branches, and splitting off rolling just for this warning isn't worth it.

@mintar mintar closed this Apr 26, 2024
@mintar mintar deleted the set-cmake-policy branch April 26, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant