Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk-typescript #555

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Conversation

wow-sven
Copy link
Collaborator

@wow-sven wow-sven commented Aug 1, 2023

  1. rpc call test successful
  2. add rpc cros

Todo:

  1. Complete the account
  2. Replace bcs
  3. unit test
  4. e2e test

@wow-sven wow-sven requested a review from jolestar August 1, 2023 19:12
@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2023 7:12pm

@wow-sven wow-sven requested a review from yubing744 August 1, 2023 19:17
* Class for creating and managing Aptos account
* TODO: authKey, rotate their private key(s)
*/
export class RoochAccount {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the game scene, there needs to be a method to randomly generate a RoochAccount, for example:

static createRandom(): RoochAccount

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I haven't committed all the code yet, because there are still problems

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@yubing744 yubing744 self-requested a review August 2, 2023 15:16
@yubing744 yubing744 merged commit a54409a into rooch-network:main Aug 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants