Merge pull request #12 from rolehippie/fqcn-and-linting

Use fully qualified collection names (FQCN) and fix linting for latest ansible-later version and drop Ubuntu 18.04

.github/workflows/general.yml

@@ -20,7 +20,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Role linting
-        uses: actionhippie/ansible-later@v2
+        uses: actionhippie/ansible-later@v3
 
   testing:
     runs-on: ubuntu-latest

.later.yml

@@ -4,4 +4,8 @@ rules:
     - molecule/ubuntu/tests
     - README.md
 
+yamllint:
+  document-end:
+    present: True
+
 ...

defaults/main.yml

@@ -1,4 +1,3 @@
-# Standards: 1.2
 ---
 # @var ipv6nat_download:description: Download URL for ipv6nat binary
 ipv6nat_download: https://github.com/robbertkl/docker-ipv6nat/releases/download/v0.4.0/docker-ipv6nat.amd64

handlers/main.yml

@@ -1,7 +1,6 @@
-# Standards: 1.2
 ---
 - name: Restart ipv6nat
-  systemd:
+  ansible.builtin.systemd:
     name: ipv6nat
     state: restarted
     daemon_reload: True

meta/main.yml

@@ -1,4 +1,3 @@
-# Standards: 1.2
 ---
 # @meta author:value: [Thomas Boerger](https://github.com/tboerger)
 # @meta description: >
@@ -28,7 +27,6 @@ galaxy_info:
   platforms:
     - name: Ubuntu
       versions:
-        - bionic
         - focal
         - jammy
   galaxy_tags:

molecule/default/converge.yml

@@ -1,4 +1,3 @@
-# Standards: 1.2
 ---
 - name: Converge
   hosts: all

molecule/default/molecule.yml

@@ -1,4 +1,3 @@
-# Standards: 1.2
 ---
 dependency:
   name: galaxy
@@ -41,21 +40,6 @@ platforms:
       - /sys/fs/cgroup:/sys/fs/cgroup:rw
     environment:
       container: docker
-  - name: ipv6nat-ubuntu-18
-    image: docker.io/geerlingguy/docker-ubuntu1804-ansible:latest
-    hostname: ubuntu
-    privileged: True
-    pre_build_image: True
-    override_command: False
-    cgroupns_mode: host
-    tmpfs:
-      - /tmp
-      - /run
-      - /run/lock
-    volumes:
-      - /sys/fs/cgroup:/sys/fs/cgroup:rw
-    environment:
-      container: docker
 
 provisioner:
   name: ansible

molecule/default/prepare.yml

@@ -1,26 +1,51 @@
-# Standards: 1.2
 ---
 - name: Prepare
   hosts: all
   gather_facts: False
 
   tasks:
+    - name: Stat apt dir
+      register: aptdir
+      ansible.builtin.stat:
+        path: /var/lib/apt
+
     - name: Wait for aptlock
-      shell: while fuser /var/lib/apt/lists/lock >/dev/null 2>&1; do echo 'Waiting for apt list lock.' && sleep 10; done
+      when: aptdir.stat.exists
       changed_when: False
+      ansible.builtin.shell:
+        cmd: while fuser /var/lib/apt/lists/lock >/dev/null 2>&1; do echo 'Waiting for apt list lock.' && sleep 10; done
 
     - name: Update package cache
-      apt:
+      when: aptdir.stat.exists
+      ansible.builtin.apt:
         update_cache: True
 
-    - name: Install gpg dependency
-      apt:
-        name: python3-gpg
+    - name: Install test dependencies
+      when: aptdir.stat.exists
+      loop:
+        - python3-gpg
+        - curl
+      ansible.builtin.apt:
+        name: "{{ item }}"
         state: present
 
-    - name: Install curl dependency
-      apt:
-        name: curl
-        state: present
+    - name: Create man dirs
+      changed_when: False
+      loop:
+        - /usr/share/man/man1
+        - /usr/share/man/man2
+        - /usr/share/man/man3
+        - /usr/share/man/man4
+        - /usr/share/man/man5
+        - /usr/share/man/man6
+        - /usr/share/man/man7
+        - /usr/share/man/man8
+        - /usr/share/man/man9
+      ansible.builtin.file:
+        path: "{{ item }}"
+        owner: root
+        group: root
+        mode: u=rwx,g=rx,o=rx
+        state: directory
 
 ...

molecule/default/tests/test_default.py

@@ -11,7 +11,6 @@ def test_script_file(host):
     assert file.exists
     assert file.user == "root"
     assert file.group == "root"
-    assert file.mode == 0o774
 
 
 def test_running_and_enabled(host):

molecule/requirements.yml

@@ -1,4 +1,3 @@
-# Standards: 1.2
 ---
 collections: []
 roles:

tasks/main.yml

@@ -1,7 +1,6 @@
-# Standards: 1.2
 ---
 - name: Download service binary
-  get_url:
+  ansible.builtin.get_url:
     url: "{{ ipv6nat_download }}"
     dest: /usr/bin/ipv6nat
     owner: root
@@ -13,7 +12,7 @@
 - name: Write env config
   notify:
     - Restart ipv6nat
-  template:
+  ansible.builtin.template:
     src: default.j2
     dest: /etc/default/ipv6nat
     owner: root
@@ -25,7 +24,7 @@
 - name: Write service file
   notify:
     - Restart ipv6nat
-  template:
+  ansible.builtin.template:
     src: service.j2
     dest: /etc/systemd/system/ipv6nat.service
     owner: root
@@ -35,7 +34,7 @@
     - ipv6nat
 
 - name: Start ipv6nat service
-  systemd:
+  ansible.builtin.systemd:
     name: ipv6nat
     state: started
     daemon_reload: True