v4 #124
Open
v4 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rough draft of adding individual interfaces * variable name changes for different options * Make all changes except a few that are questionable * Take out warning since rootDir defaults * Make variable optional * Make rootDir mandatory, fixes 8 failing tests * make stagingDir mandatory for zip package, fixes 1 test * forgot 2 lines from last commit message * Fix 1 more test * Make outfile mandatory in publishOptions, fixes 12 tests * fix 1 more test over copying mistake * added stagingDir to prepublishToStaging tests to get 10 more tests to pass, all are passing now * Changed a few more interfaces that I had forgotten * Attempt to debug github tests * Test was fixed on github * Fix missing coverage * Fix some incorrect interface optional settings. Fix some tests --------- Co-authored-by: Bronley Plumb <[email protected]>
* Rough draft of adding individual interfaces * variable name changes for different options * Make all changes except a few that are questionable * Take out warning since rootDir defaults * Make variable optional * Make rootDir mandatory, fixes 8 failing tests * make stagingDir mandatory for zip package, fixes 1 test * forgot 2 lines from last commit message * Fix 1 more test * Make outfile mandatory in publishOptions, fixes 12 tests * fix 1 more test over copying mistake * added stagingDir to prepublishToStaging tests to get 10 more tests to pass, all are passing now * Changed a few more interfaces that I had forgotten * Attempt to debug github tests * Test was fixed on github * Fix missing coverage * delete retainStagingFolder --------- Co-authored-by: Bronley Plumb <[email protected]>
* Rough draft of adding individual interfaces * variable name changes for different options * Make all changes except a few that are questionable * Take out warning since rootDir defaults * Make variable optional * Make rootDir mandatory, fixes 8 failing tests * make stagingDir mandatory for zip package, fixes 1 test * forgot 2 lines from last commit message * Fix 1 more test * Make outfile mandatory in publishOptions, fixes 12 tests * fix 1 more test over copying mistake * added stagingDir to prepublishToStaging tests to get 10 more tests to pass, all are passing now * Changed a few more interfaces that I had forgotten * Attempt to debug github tests * Test was fixed on github * Fix missing coverage * delete retainStagingFolder * Remove changing back slashes to forward slashes * put standardizePath() back * Put back more code * Delete toFrowardSlashes test * No longer force all paths to unix style * Fix windows issues * fix coverage failure * Edit readme * Add tests to check for escaped and unescaped glob patterns * Update README.md Co-authored-by: Bronley Plumb <[email protected]> * Update README.md Co-authored-by: Bronley Plumb <[email protected]> * change tests to accomodate windows machines * Process slashes properly --------- Co-authored-by: Bronley Plumb <[email protected]>
* Make change to assume dest folder. Delete 2 old tests that looked for old behavior, add 2 more tests that look for new behavior * Sort files * Update src/RokuDeploy.ts Co-authored-by: Bronley Plumb <[email protected]> * Removed redundant entry.dest is null situation --------- Co-authored-by: Bronley Plumb <[email protected]>
* Make change to assume dest folder. Delete 2 old tests that looked for old behavior, add 2 more tests that look for new behavior * Sort files * Update src/RokuDeploy.ts Co-authored-by: Bronley Plumb <[email protected]> * Removed redundant entry.dest is null situation * Added a few commands, not all are working correctly * Move commands to their own file * More command files * Change commands to help with tests * Add testing suite for all cli (2 tests are not working) * Updated cli file after adding in commands and tests * Fixed a few test cases * Change name and input of table helper * Changed name of toTable * Make test for objectToTable * add yargs to pacjage.json * add package-lock.json * add new line at eof * Add test for coverage, also remove an unncessary '?' * Change function name * last function name change --------- Co-authored-by: Bronley Plumb <[email protected]>
* Make change to assume dest folder. Delete 2 old tests that looked for old behavior, add 2 more tests that look for new behavior * Sort files * Update src/RokuDeploy.ts Co-authored-by: Bronley Plumb <[email protected]> * Removed redundant entry.dest is null situation * Added a few commands, not all are working correctly * Move commands to their own file * More command files * Change commands to help with tests * Add testing suite for all cli (2 tests are not working) * Updated cli file after adding in commands and tests * Fixed a few test cases * Change name and input of table helper * Delete all functions, start fixing errors that pop up * Changed name of toTable * Make test for objectToTable * add yargs to pacjage.json * add package-lock.json * add new line at eof * Add test for coverage, also remove an unncessary '?' * last merge change --------- Co-authored-by: Bronley Plumb <[email protected]>
…ns (#142) * Make change to assume dest folder. Delete 2 old tests that looked for old behavior, add 2 more tests that look for new behavior * Sort files * Update src/RokuDeploy.ts Co-authored-by: Bronley Plumb <[email protected]> * Removed redundant entry.dest is null situation * Added a few commands, not all are working correctly * Move commands to their own file * More command files * Change commands to help with tests * Add testing suite for all cli (2 tests are not working) * Updated cli file after adding in commands and tests * Fixed a few test cases * Change name and input of table helper * Totally broken code, but have the right names * Changed name of toTable * Make test for objectToTable * add yargs to pacjage.json * add package-lock.json * add new line at eof * Add test for coverage, also remove an unncessary '?' * tweaks * tweaks * get from json stuff * Correct imports * Last of the fsExtra changes * Create a load from json util, clean up cli.ts file with fleshing out comments, delete unnecessary command/tests/options, partially fix exec command * Adding cli tests * Delete deployAndSignPackage tests, a deleted function in rokudeploy * Add defaultsFromJson tests * Move some tests to utils test file, re add other functions that might have been accidentally deleted, fix some errors with fsExtra * Change signExistingPackage to CreateSignedPackage * Delete retrieveSignedPackage * Move getFilePaths * Random changes I forgot to put in the other pushes * Change to different notation since getOutputZipFilePath and getOutputPkgPath were made private * Change notation for normalizeDeviceInfoFieldValue since it was made privete * Change notation for parsedManifestFromString and ParseManifest since being made private * Change deleteInstalledChannel to deleteDevChannel, other small changes * Add stagingDir, fix zip/deleteDevChannel/captureScreenshot function calls, delete Deploy function * Fix commands * change defaults from json function, fix some tests * fix index, fix makezip, getfilepaths, sideload * Add options from json ability to each command to each command * remove bsconfig, fix cli file with key press commands, fix key press functions and add options * fix getoptionsfromjson * delete unnecessary commands, fix some tests * change to captureScreenshot * Fix a bunch of tests * Fix up the last few tests and cli commands * Changing coverage check to false * Fix failing tests on windows * Delete comment * Change publish to sideload everywhere else * Move deploy tests to test exec command * Throw new error for wrong device id, and add test to test for it * Delete creating variable options since it was unused * Add function description * Inline exec command options * Remove retainsStagingDir, zipCallBackInfo, incrementBuildNumber, and add back tests for createPackage * Delete convertToSquashfs, move deployAndSignPackage tests to cli, move retrieveSignedPackage tests to under createSignedPackage * Change prepublishToStaging to stage * Change the way close channel works * Update src/RokuDeploy.ts Co-authored-by: Bronley Plumb <[email protected]> * Add outFile to Zip, delete zipPackage --------- Co-authored-by: Milap Naik <[email protected]>
* Make change to assume dest folder. Delete 2 old tests that looked for old behavior, add 2 more tests that look for new behavior * Sort files * Update src/RokuDeploy.ts Co-authored-by: Bronley Plumb <[email protected]> * Removed redundant entry.dest is null situation * Added a few commands, not all are working correctly * Move commands to their own file * More command files * Change commands to help with tests * Add testing suite for all cli (2 tests are not working) * Updated cli file after adding in commands and tests * Fixed a few test cases * Change name and input of table helper * Totally broken code, but have the right names * Changed name of toTable * Make test for objectToTable * add yargs to pacjage.json * add package-lock.json * add new line at eof * Add test for coverage, also remove an unncessary '?' * tweaks * tweaks * get from json stuff * Correct imports * Last of the fsExtra changes * Create a load from json util, clean up cli.ts file with fleshing out comments, delete unnecessary command/tests/options, partially fix exec command * Adding cli tests * Delete deployAndSignPackage tests, a deleted function in rokudeploy * Add defaultsFromJson tests * Move some tests to utils test file, re add other functions that might have been accidentally deleted, fix some errors with fsExtra * Change signExistingPackage to CreateSignedPackage * Delete retrieveSignedPackage * Move getFilePaths * Random changes I forgot to put in the other pushes * Change to different notation since getOutputZipFilePath and getOutputPkgPath were made private * Change notation for normalizeDeviceInfoFieldValue since it was made privete * Change notation for parsedManifestFromString and ParseManifest since being made private * Change deleteInstalledChannel to deleteDevChannel, other small changes * Add stagingDir, fix zip/deleteDevChannel/captureScreenshot function calls, delete Deploy function * Fix commands * change defaults from json function, fix some tests * fix index, fix makezip, getfilepaths, sideload * Add options from json ability to each command to each command * remove bsconfig, fix cli file with key press commands, fix key press functions and add options * fix getoptionsfromjson * delete unnecessary commands, fix some tests * change to captureScreenshot * Fix a bunch of tests * Fix up the last few tests and cli commands * Changing coverage check to false * Fix failing tests on windows * Delete comment * Change publish to sideload everywhere else * Move deploy tests to test exec command * Throw new error for wrong device id, and add test to test for it * Delete creating variable options since it was unused * Add function description * Inline exec command options * Remove retainsStagingDir, zipCallBackInfo, incrementBuildNumber, and add back tests for createPackage * Delete convertToSquashfs, move deployAndSignPackage tests to cli, move retrieveSignedPackage tests to under createSignedPackage * Change prepublishToStaging to stage * Change the way close channel works * Update src/RokuDeploy.ts Co-authored-by: Bronley Plumb <[email protected]> * Add outFile to Zip, delete zipPackage * StagingDir is defaulted anyway so this error will never occur * Delete MissingRequiredOptionError * Add checkRequiredOptions function to test for required options * Add checking for required options in sendKeyEvent function, start testing * Add check for if options are part of the defined interface that they are being called with * Add check for various required options and add tests for each one * take out it.only in tests * Delete old MissingRequiredOptionError tests * fix tests * Fix lint error * Upgrade node to 14.7.0 * Undo last commit wrong branch * Get rid of individual options checks * Fixed option type in tests function --------- Co-authored-by: Bronley Plumb <[email protected]>
* Make change to assume dest folder. Delete 2 old tests that looked for old behavior, add 2 more tests that look for new behavior * Sort files * Update src/RokuDeploy.ts Co-authored-by: Bronley Plumb <[email protected]> * Removed redundant entry.dest is null situation * Added a few commands, not all are working correctly * Move commands to their own file * More command files * Change commands to help with tests * Add testing suite for all cli (2 tests are not working) * Updated cli file after adding in commands and tests * Fixed a few test cases * Change name and input of table helper * Totally broken code, but have the right names * Changed name of toTable * Make test for objectToTable * add yargs to pacjage.json * add package-lock.json * add new line at eof * Add test for coverage, also remove an unncessary '?' * tweaks * tweaks * get from json stuff * Correct imports * Last of the fsExtra changes * Create a load from json util, clean up cli.ts file with fleshing out comments, delete unnecessary command/tests/options, partially fix exec command * Adding cli tests * Delete deployAndSignPackage tests, a deleted function in rokudeploy * Add defaultsFromJson tests * Move some tests to utils test file, re add other functions that might have been accidentally deleted, fix some errors with fsExtra * Change signExistingPackage to CreateSignedPackage * Delete retrieveSignedPackage * Move getFilePaths * Random changes I forgot to put in the other pushes * Change to different notation since getOutputZipFilePath and getOutputPkgPath were made private * Change notation for normalizeDeviceInfoFieldValue since it was made privete * Change notation for parsedManifestFromString and ParseManifest since being made private * Change deleteInstalledChannel to deleteDevChannel, other small changes * Add stagingDir, fix zip/deleteDevChannel/captureScreenshot function calls, delete Deploy function * Fix commands * change defaults from json function, fix some tests * fix index, fix makezip, getfilepaths, sideload * Add options from json ability to each command to each command * remove bsconfig, fix cli file with key press commands, fix key press functions and add options * fix getoptionsfromjson * delete unnecessary commands, fix some tests * change to captureScreenshot * Fix a bunch of tests * Fix up the last few tests and cli commands * Changing coverage check to false * Fix failing tests on windows * Delete comment * Change publish to sideload everywhere else * Move deploy tests to test exec command * Throw new error for wrong device id, and add test to test for it * Delete creating variable options since it was unused * Add function description * Inline exec command options * Remove retainsStagingDir, zipCallBackInfo, incrementBuildNumber, and add back tests for createPackage * Delete convertToSquashfs, move deployAndSignPackage tests to cli, move retrieveSignedPackage tests to under createSignedPackage * Change prepublishToStaging to stage * Change the way close channel works * Update src/RokuDeploy.ts Co-authored-by: Bronley Plumb <[email protected]> * Add outFile to Zip, delete zipPackage * StagingDir is defaulted anyway so this error will never occur * Delete MissingRequiredOptionError * Add checkRequiredOptions function to test for required options * Add checking for required options in sendKeyEvent function, start testing * Add check for if options are part of the defined interface that they are being called with * Add check for various required options and add tests for each one * take out it.only in tests * Delete old MissingRequiredOptionError tests * fix tests * Fix lint error * Upgrade as many packages as possible, delete chalk stub * Bring back chalk by downgrading sinon to v12 * New package-lock * Upgrade node to 14.7.0 * Undo last commit wrong branch * Upgrade node in build script to 14.17 * Get rid of individual options checks * Fixed option type in tests function * Fixing eslint libraries to be compatible with the version of node we are using * Fix lint errors: sorting unions and importing types in the same line as packages * Fix lint errors: lines around comments set to false, prefer nullish coalescing set to false, propert results should be set as a class property, optional chaining, and no redundant types * Fix 2 more lint errors * Fix jszip error * Undo last change * Turn off prefer optional chain * Disable duplicate imports error one time * move eslint to a dev dependency * Fix eslint errors * Added npm install package lock, which actually fixed a different issue * add eslint plugin import, fix logical-assignment-operators error --------- Co-authored-by: Bronley Plumb <[email protected]>
* Make change to assume dest folder. Delete 2 old tests that looked for old behavior, add 2 more tests that look for new behavior * Sort files * Update src/RokuDeploy.ts Co-authored-by: Bronley Plumb <[email protected]> * Removed redundant entry.dest is null situation * Added a few commands, not all are working correctly * Move commands to their own file * More command files * Change commands to help with tests * Add testing suite for all cli (2 tests are not working) * Updated cli file after adding in commands and tests * Fixed a few test cases * Change name and input of table helper * Totally broken code, but have the right names * Changed name of toTable * Make test for objectToTable * add yargs to pacjage.json * add package-lock.json * add new line at eof * Add test for coverage, also remove an unncessary '?' * tweaks * tweaks * get from json stuff * Correct imports * Last of the fsExtra changes * Create a load from json util, clean up cli.ts file with fleshing out comments, delete unnecessary command/tests/options, partially fix exec command * Adding cli tests * Delete deployAndSignPackage tests, a deleted function in rokudeploy * Add defaultsFromJson tests * Move some tests to utils test file, re add other functions that might have been accidentally deleted, fix some errors with fsExtra * Change signExistingPackage to CreateSignedPackage * Delete retrieveSignedPackage * Move getFilePaths * Random changes I forgot to put in the other pushes * Change to different notation since getOutputZipFilePath and getOutputPkgPath were made private * Change notation for normalizeDeviceInfoFieldValue since it was made privete * Change notation for parsedManifestFromString and ParseManifest since being made private * Change deleteInstalledChannel to deleteDevChannel, other small changes * Add stagingDir, fix zip/deleteDevChannel/captureScreenshot function calls, delete Deploy function * Fix commands * change defaults from json function, fix some tests * fix index, fix makezip, getfilepaths, sideload * Add options from json ability to each command to each command * remove bsconfig, fix cli file with key press commands, fix key press functions and add options * fix getoptionsfromjson * delete unnecessary commands, fix some tests * change to captureScreenshot * Fix a bunch of tests * Fix up the last few tests and cli commands * Changing coverage check to false * Fix failing tests on windows * Delete comment * Change publish to sideload everywhere else * Move deploy tests to test exec command * Throw new error for wrong device id, and add test to test for it * Delete creating variable options since it was unused * Add function description * Inline exec command options * Remove retainsStagingDir, zipCallBackInfo, incrementBuildNumber, and add back tests for createPackage * Delete convertToSquashfs, move deployAndSignPackage tests to cli, move retrieveSignedPackage tests to under createSignedPackage * Change prepublishToStaging to stage * Change the way close channel works * Update src/RokuDeploy.ts Co-authored-by: Bronley Plumb <[email protected]> * Add outFile to Zip, delete zipPackage * StagingDir is defaulted anyway so this error will never occur * Delete MissingRequiredOptionError * Add checkRequiredOptions function to test for required options * Add checking for required options in sendKeyEvent function, start testing * Add check for if options are part of the defined interface that they are being called with * Add check for various required options and add tests for each one * take out it.only in tests * Delete old MissingRequiredOptionError tests * fix tests * Fix lint error * Upgrade as many packages as possible, delete chalk stub * Bring back chalk by downgrading sinon to v12 * New package-lock * Upgrade node to 14.7.0 * Undo last commit wrong branch * Upgrade node in build script to 14.17 * Get rid of individual options checks * Fixed option type in tests function * Fixing eslint libraries to be compatible with the version of node we are using * Fix lint errors: sorting unions and importing types in the same line as packages * Fix lint errors: lines around comments set to false, prefer nullish coalescing set to false, propert results should be set as a class property, optional chaining, and no redundant types * Fix 2 more lint errors * Fix jszip error * Undo last change * Turn off prefer optional chain * Disable duplicate imports error one time * move eslint to a dev dependency * Fix eslint errors * Added npm install package lock, which actually fixed a different issue * add eslint plugin import, fix logical-assignment-operators error * Make screenshotDir use CWD * Add cwd to command line and interfaces that use paths * Add cwd tests * Fix lint issue * Fix windows tests * Delete duplicate stage * Add test for relative screenshotDir prop based on cwd --------- Co-authored-by: Bronley Plumb <[email protected]>
* Update wrong host password error message (#134) * Update wrong host password error message * Fix unit test to look for the updated message * Get 100% code coverage * Update changelog for v3.11.2 * 3.11.2 * Retry the convertToSquahsfs request given the HPE_INVALID_CONSTANT error (#145) * Retry the convertToSquahsfs request given the HPE_INVALID_CONSTANT error * Add a clarifying comment and a new test case * Add two more test cases to get to 100% code coverage * Another test in pursuit of 100% * Remove optional chaining on catch. The error is always going to be set * Update changelog for v3.11.3 * 3.11.3 * Support overriding various package upload form data (#136) * Support overriding various package upload form data * adds support for squashfs deployments --------- Co-authored-by: George Cook <[email protected]> * Update changelog for v3.12.0 * 3.12.0 * Merge branch 'master' into v4 # Conflicts: # CHANGELOG.md # package-lock.json # package.json # src/RokuDeploy.spec.ts # src/RokuDeploy.ts # src/RokuDeployOptions.ts - deleteDevChannel call was added which changed order of sideload post requests - output file in makezip was changed to writefile * readme info for retain staging dir deleted * readded example * fix package lock * Fix Ci --------- Co-authored-by: Christian-Holbrook <[email protected]> Co-authored-by: Bronley Plumb <[email protected]> Co-authored-by: George Cook <[email protected]>
* Change usage section * A few styling changes in readme * More readme changes * More Readme edits * Fix tests * More readme changes * cli file camelcase changes * minor readme edit * Fix github actions comment * Addressing comments * Update README.md Co-authored-by: Bronley Plumb <[email protected]> * Address a few comments * Minor readme update * Merge branch 'v4' into change-docs # Conflicts: # src/RokuDeploy.spec.ts --------- Co-authored-by: Bronley Plumb <[email protected]>
* Update files array * change file order
Merge branch 'master' into v4 # Conflicts: # CHANGELOG.md # package-lock.json # package.json # src/RokuDeploy.spec.ts # src/RokuDeploy.ts # src/RokuDeployOptions.ts
* install npm logger package * Change current logger use to the npm package, delete in house logging functions * Added a few more logging options * Import logger differently in roku deploy options * Added a few logging options * Fix tests
* Add new v4 section and table of contents * Added to the Readme to discuss breaking changes * Make files array changes elsewhere in readme * More readme changes * Update README.md * Tweaks to the readme. * Make readme prettier * fix table of contents link * Another readme update * Organize function changes better * make function list prettier * Add links to functions * Fix links since they don't work in code blocks * fix link 1 more time * Change to 1 link --------- Co-authored-by: Bronley Plumb <[email protected]>
* Add interactive remote mode * Rename interactive remote control function naming * Rename RemoteControl to RemoteControlCommand --------- Co-authored-by: Brian Leighty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bucket for all the v4 changes. Don't merge this until they're all done!