Expose internal DynObjectStore from PyObjectStore struct
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
1 task
kylebarron
added a commit
to geoarrow/geoarrow-rs
that referenced
this pull request
Mar 6, 2024
…ation (#536) Fixes first problem in #534. Uses my own branch pending roeap/object-store-python#11 Todo: - [x] Add minimal type hinting for `ObjectStore` class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
geoarrow-rsI'm implementing parsers for geospatial file formats using object-store. I also have Python bindings, and it would be nice to reuse the builders inobject-store-python, but I need direct access to the underlyingobject-storeinstance.geoarrow/geoarrow-rs#536 uses this PR on my branch and successfully reads a FlatGeobuf file from S3.