Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yaml safe load #406

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Fix yaml safe load #406

merged 2 commits into from
Jul 11, 2024

Conversation

g-arjones
Copy link
Contributor

@g-arjones g-arjones commented Jul 4, 2024

Passing whitelisted classes to YAML$safe_load as a positional argument has been deprecated in Psych v3.1.0 (Ruby v2.7.8) and completely removed in v4.0.3 (Ruby v3.1.0)

@g-arjones g-arjones requested a review from doudou July 4, 2024 19:13
@g-arjones
Copy link
Contributor Author

@2maz Could you have a look at this, please?

@g-arjones g-arjones requested review from 2maz and removed request for doudou July 10, 2024 02:27
Copy link
Member

@2maz 2maz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I see, however, that checks fail due to other reasons.

@g-arjones g-arjones force-pushed the fix_yaml_safe_load branch 2 times, most recently from b695ebe to 2bb32f2 Compare July 10, 2024 20:43
@g-arjones
Copy link
Contributor Author

It looks like there's actually something wrong with the bundle versioning code. Unfortunately, I can't have a deeper look right now.

Thanks for the review.

@g-arjones g-arjones merged commit fbbb95d into master Jul 11, 2024
4 of 6 checks passed
@g-arjones g-arjones deleted the fix_yaml_safe_load branch July 11, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants