Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to disable the .git suffix #403

Merged
merged 4 commits into from
May 7, 2024
Merged

Conversation

annaborn
Copy link
Contributor

@annaborn annaborn commented Mar 8, 2024

Hello Sylvain @doudou !

Here is the commit to the issue #400.
I thought, there is only one possible suffix for git repositories, .git. So I have modified your advice from the issue, and added the option to disable the suffix without the possibility to modify the suffix itself.
So at the end, the user can leave everything how it is, and per default .git will be added to the repos. Or use add_suffix: false to get the repository urls without .git ending.

I tested it on my local setup. Where I had two git server configurations: one without add_suffix option and one with add_suffix: false.

@annaborn
Copy link
Contributor Author

annaborn commented Apr 5, 2024

@doudou Sylvain, could you please check the Pull Request?

@doudou doudou merged commit 1c0a06c into rock-core:master May 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants