-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create YCMBootstrapFetch to permit projects to bootstrap YCM using FetchContent #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
changed the title
[WIP] Create YCMBootstrapFetch to permit projects to bootstrap YCM using FetchContent
Create YCMBootstrapFetch to permit projects to bootstrap YCM using FetchContent
Apr 13, 2022
Windows GitHub Action builds, before this PR the bootstrapping took ~25 seconds and ~22 seconds in subsequent builds:
After, it takes ~5 seconds on first build and ~3 on subsequent builds:
|
The tests in in robotology/robotology-superbuild#1078 worked fine, the PR is now ready for review. |
Nicogene
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
YCMBootstrapFetch.cmake
script to permit projects to bootstrap YCM by just usingFetchContent
.A different file is created as the semantics of this new bootstrap script is a bit different, as it just make YCM available in the project, but it does not also adds it as a subproject in the superbuild sense. Superbuilds that want to switch from
YCMBootstrap.cmake
toYCMBootstrapFetch.cmake
need to createBuildYCM.cmake
script, and appropriately callfind_or_build_package(YCM)
, as done for example in the robotology-superbuild in robotology/robotology-superbuild#1078 .Fix #138 .