Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for storage investment #42

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

Conversation

jnnr
Copy link
Collaborator

@jnnr jnnr commented Oct 13, 2021

This PR adds tests of storage investment with the constraint of capacity_potential, storage_capacity_potential, capacity_potential_charge/discharge for Storage and AssymetricStorage.

@jnnr
Copy link
Collaborator Author

jnnr commented Jan 24, 2022

Added constraint tests for storage and asymmetric storage and checked the lp-files:

  • storage_investment_greenfield: Ok
  • asymmetric_storage_investment_greenfield: Ok
  • storage_investment_brown_field:
    • Bug in constraint c_e_GenericInvestmentStorageBlock_power_coupled(storage)_
      Input and output capacity should be the same.
      Fix: Pass self.existing to the invest object of the output flow.
    • Not a bug, but may be better to adapt it: Currently, potentials relate to the invested capacity on top of existing, not on the sum of existing and additionally invested. E.g., if there is an existing capacity of 3 (MW) and a potential of 5 (MW), the max would be 8 MW. Usually though, potential means the total potential, including the part of it that is already realized. Should pass max = potential - existing to the investment objects.
    • Both are addressed in Fix: Storage Investment oemof/oemof-tabular#33
  • asymmetric_storage_investment_brown_field:
    • Again, potentials relate to invested capacity, irrespective of how much capacity already exists. This does not reflect the common usage of "potential". Defined in the bounds of the investment variables.
    • Done in dc67789

@jnnr jnnr added this to the v0.0.1 milestone Oct 12, 2022
@jnnr
Copy link
Collaborator Author

jnnr commented Nov 21, 2022

TODO: Keep the tests and fixes for assymetric storage in a separate branch, but drop the test for storage to avoid duplication with oemof.tabular.

I keep this open and postpone this to the next release. In the meantime, AssymetricStorage could move to oemof.tabular's experimental facades anyway oemof/oemof-tabular#46.

@jnnr jnnr modified the milestones: v0.0.1, v0.0.2 Nov 21, 2022
@jnnr jnnr removed their assignment Feb 16, 2023
@jnnr jnnr marked this pull request as draft February 16, 2023 15:43
@MaGering MaGering modified the milestones: v0.0.2, v0.0.3 Aug 31, 2023
@MaGering MaGering modified the milestones: v0.0.3, v0.0.4 Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants