Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle not found links better, configurable URLs #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Hans5958
Copy link

@Hans5958 Hans5958 commented May 28, 2022

🇺🇸 🇬🇧

Currently, I don't know what language to use for the org. I saw RISTEK often speaks English, but as an Indonesian-based organization, it just feels wrong. It doesn't stop me to contribute, though

Usually, when the links are not found, it would redirect us into a bland 404 page. This PR would make it so it would redirect to the index, and add a nice toast afterwards.

image

Also changed on this PR:

It should work, but I since I don't know much about React/Next.JS, it might not work as expected on prod? I tried my best and I know it would work theoritically, but please check it!

Some other changes from me will be made in later PRs, such as docs and Wrangler stuff, but I think that could be done later.

🇮🇩

Untuk sekarang, saya kurang tahu bahasa apa yang kugunakan di dalam organisasi. Saya lihat RISTEK lebih sering pakai bahasa Inggris, tapi sebagai suatu organisasi Indonesia, kelihatannya agak sedikit aneh. Tetap saja, ini tidak akan menghentikanku untuk berkontribusi.

Biasanya, kalau linknya tidak ditemukan, ia akan mengalihkan kita kepada sebuah halaman 404. PR ini akan membuat ia mengalihkan kita ke pada halaman index, dan memunculkan sebuah toast setelahnya.

image

Harusnya sih bisa, tapi karena saya tidak begitu paham tentang React/Next.JS, ini mungkin tidak akan bekerja semestinya di prod? Saya sudah mencobanya sebisaku dan saya tahu ini harusnya bekerja di atas kertas, tapi mohon diperiksa!

Beberapa perubahan lainnya di PR ini:

Akan ada perubahan lain dari saya pada PR-PR berikutnya, seperti docs dan terkait Wrangler, tapi saya rasa itu bisa nanti.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic link for self-customized app domain
1 participant