176 missing description for mip csr #272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Fixed mie to be defined by Sm not I extension. Description for mip and mie is now shared mimicing ISA manual.
dhower-qc
requested changes
Nov 14, 2024
| in the `sip` register and is maskable using the `sie` register. | ||
| Otherwise, the corresponding bits in `sip` and `sie` are read-only zero. | ||
| definedBy: Sm | ||
| description: "$copy: mip.yaml#/mip/description" |
There was a problem hiding this comment.
why doesn't $ref work here? I think the intent is that it should, like so:
description:
$ref: "mip.yaml#/mip/description"Further, we don't want $copy to be hidden in a string. Assuming we need to keep $copy for some reason, it should look like:
description:
$copy: "mip.yaml#/mip/description"There was a problem hiding this comment.
I would have used $ref if it worked (it doesn't). That's because changing
description: "foo"
to
description:
some-key: "foo"
would be changing "description" from a string to a hash and that would break everything using it (which it does).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created $copy to copy string values like $ref. Added unit-level test. Fixed mie to be defined by Sm not I extension. Description for mip and mie is now shared mimicing ISA manual.
Fixes #176