Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key_binder: add whences first_page, not_first_page, last_page, not_last_page #927

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fxliang
Copy link
Contributor

@fxliang fxliang commented Aug 17, 2024

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request
add whences: first_page, not_first_page, last_page, not_last_page

it would be helpful when pattern like recognizer/patterns/money: '^/dx\d+(\.\d{0,2})?$' is set, when comma / period is binding to page up / page down.

    - { when: paging, accept: comma, send: Page_Up }
    - { when: not_last_page, accept: period, send: Page_Down }

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@fxliang fxliang changed the title key_binder: add whences first_page, not_first_page, last_page, not_last_page key_binder: add whences first_page, not_first_page, last_page, not_last_page[wip] Aug 31, 2024
@fxliang fxliang changed the title key_binder: add whences first_page, not_first_page, last_page, not_last_page[wip] key_binder: add whences first_page, not_first_page, last_page, not_last_page Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant