Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CMake Scripts Composing #749

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Improve CMake Scripts Composing #749

wants to merge 10 commits into from

Conversation

WhiredPlanck
Copy link
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #N/A

Feature

Describe feature of pull request

Improve CMake scripts composing

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@WhiredPlanck
build: directly use cmake variables in pkgconfig template
8d0a24c 
Also change the condition: only not to install on Android since Android doesn't support pkgconfig yet.
@WhiredPlanck
build: remove redundant *_STATIC flags
accd1ec 
Also rename option BUILD_STATIC to WITH_STATIC_DEPS to make people more aware of its role
@WhiredPlanck
build: slightly polish some cmake scripts
48a2341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@WhiredPlanck