added the option to specify a title when the enable function is called #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keichenblat
reviewed
May 9, 2021
| @@ -128,6 +128,7 @@ var NoSleep = function () { | |||
|
|
|||
| _classCallCheck(this, NoSleep); | |||
|
|
|||
| this.title = "No sleep"; | |||
There was a problem hiding this comment.
Use capital S here to keep the default value as-is (i.e. No Sleep)
keichenblat
reviewed
May 9, 2021
Comment on lines
-3
to
+9
| <head> | ||
| <title>NoSleep.js - Simple Test Page</title> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| </head> | ||
| <body> | ||
| <h1>NoSleep Test Page</h1> | ||
| <script src="../dist/NoSleep.min.js"></script> | ||
| <head> | ||
| <title>NoSleep.js - Simple Test Page</title> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| </head> | ||
| <body> | ||
| <h1>NoSleep Test Page</h1> | ||
| <script src="../dist/NoSleep.min.js"></script> |
There was a problem hiding this comment.
This diff seems to originate due to the use of different format settings from the repo's owner. I suggest reverting those changes because the owner may not like them
|
Thank you Marco 👑 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey man! I'm Marco, a Frontend Developer from Barcelona. I added a small feature to your already awesome package (good job btw, you saved me). I hope you like what i added even though it's not a big thing.
This PR contains a:
Motivation / Use-Case
I needed to show a particular video title when an IOS device is locked. As you can see here the "NoSleep" title is shown:
I just wanted the possibility to customize it a little bit :)