Skip to content

Commit

Permalink
jMonkeyEngine#2279 Add a readme for the screenshot tests and change t…
Browse files Browse the repository at this point in the history
…he name of the report
  • Loading branch information
richardTingle committed Jun 9, 2024
1 parent cd14a1a commit a2c1b23
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 1 deletion.
50 changes: 50 additions & 0 deletions jme3-screenshot-tests/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
# jme3-screenshot-tests

This module contains tests that compare screenshots of the JME3 test applications to reference images. The tests are run using
the following command:

```
./gradlew :jme3-screenshot-test:screenshotTest
```

This will create a report in `jme3-screenshot-test/build/reports/ScreenshotDiffReport.html` that shows the differences between the reference images and the screenshots taken during the test run. Note that this is an ExtentReport.

This is most reliable when run on the CI server. The report can be downloaded from the artifacts section of the pipeline (once the full pipeline has completed). If you go into
the Actions tab (on GitHub) and find your pipeline you can download the report from the Artifacts section. It will be called screenshot-test-report.

## Machine variability

It is important to be aware that the tests are sensitive to machine variability. Different GPUs may produce subtly different pixel outputs
(that look identical to a human user). The tests are run on a specific machine and the reference images are generated on that machine. If the tests are run on a different machine, the images may not match the reference images and this is "fine". If you run these on your local machine compare the differences by eye in the report, don't wory about failing tests.

## Parameterised tests

By default, the tests use the class and method name to produce the screenshot image name. E.g. org.jmonkeyengine.screenshottests.effects.TestExplosionEffect.testExplosionEffect_f15.png is the testExplosionEffect test at frame 15. If you are using parameterised tests this won't work (as all the tests have the same function name). In this case you should specify the image name (including whatever parameterised information to make it unique). E.g.

```
screenshotTest(
....
).setFramesToTakeScreenshotsOn(45)
.setBaseImageFileName("some_unique_name_" + theParameterGivenToTest)
.run();
)
```

## Non-deterministic (and known bad) tests

By default, screenshot variability will cause the pipeline to fail. If a test is non-deterministic (e.g. includes randomness) or
is a known accepted failure (that will be fixed "at some point" but not now) that can be non-desirable. In that case you can
change the behaviour of the test such that these are marked as warnings in the generated report but don't fail the test

```
screenshotTest(
....
).setFramesToTakeScreenshotsOn(45)
.setTestType(TestType.NON_DETERMINISTIC)
.run();
)
```

## Accepting new images

It may be the case that a change makes an improvement to the library (or the test is entirely new) and the new image should be accepted as the new reference image. To do this, copy the new image to the `src/test/resources` directory. The new image can be found in the `build/changed-images` directory, however it is very important that the image come from the reference machine. This can be obtained from the CI server. The job runs only if there is an active pull request (to one of the mainline branches; e.g. master or 3.7). If you go into the Actions tab and find your pipeline you can download the report and changed images from the Artifacts section.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public class ExtentReportExtension implements BeforeAllCallback, AfterAllCallbac
@Override
public void beforeAll(ExtensionContext context) {
if(extent==null){
ExtentSparkReporter spark = new ExtentSparkReporter("build/reports/ExtentReport.html");
ExtentSparkReporter spark = new ExtentSparkReporter("build/reports/ScreenshotDiffReport.html");
spark.config().setTheme(Theme.STANDARD);
spark.config().setDocumentTitle("Test Report");
spark.config().setReportName("JUnit Test Report");
Expand Down

0 comments on commit a2c1b23

Please sign in to comment.