Fix RDP var contains string instead of bool #5994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue with the original code is in python behavior. Python on this code: "a" or "b" will give you "b" instead of probably expected 'True' value. This is fix to avoid break of the code in the future because this variable should keep boolean value.
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
M4rtinK
approved these changes
Nov 12, 2024
|
I wouldn't be surprised by that. I just works in most of the cases. I found that by accident when I was debugging other issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with the original code is in python behavior. Python on this code:
"a" or "b"
will give you
"b"
instead of probably expected 'True' value. This is fix to avoid break of the code in the future because this variable should keep boolean value.