Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Collect release notes for F41 #5971

Merged
merged 1 commit into from
Nov 4, 2024
Merged

docs: Collect release notes for F41 #5971

merged 1 commit into from
Nov 4, 2024

Conversation

KKoukiou
Copy link
Contributor

No description provided.

@KKoukiou KKoukiou marked this pull request as ready for review October 31, 2024 06:30
M4rtinK
M4rtinK approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! :)

jkonecny12
jkonecny12 requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes from my side.

Also I think we should make the lines consistent. Currently every part has different line size. It seems more or less consistent in the rest of the document.

docs/release-notes.rst Show resolved Hide resolved
docs/release-notes.rst Outdated Show resolved Hide resolved
@KKoukiou
Copy link
Contributor Author

KKoukiou commented Nov 1, 2024

A few notes from my side.

Also I think we should make the lines consistent. Currently every part has different line size. It seems more or less consistent in the rest of the document.

Done. Good point.

@KKoukiou
Copy link
Contributor Author

KKoukiou commented Nov 1, 2024

/kickstart-tests --waive docs only

@jkonecny12
Copy link
Member

Seems there is a commit which shouldn't be here. Otherwise it looks good.

@KKoukiou
Copy link
Contributor Author

KKoukiou commented Nov 4, 2024

Seems there is a commit which shouldn't be here. Otherwise it looks good.

I was just not rebased.

jkonecny12
jkonecny12 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkonecny12
Copy link
Member

/kickstart-test --waive docs only

@KKoukiou KKoukiou merged commit 840d6a4 into rhinstaller:master Nov 4, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkonecny12 jkonecny12 jkonecny12 approved these changes

@M4rtinK M4rtinK M4rtinK approved these changes

Assignees
No one assigned
Labels
documentation f42 Fedora 42
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KKoukiou @jkonecny12 @M4rtinK