Fstab handling moves to blivet #5793
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japokorn
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
Anaconda handling fstab is something that should be done by blivet. This moves the fstab logic into the blivet. Crypttab and blkidtab handling is not supported by blivet yet so it remains mostly unchanged (for now) Added unit_tests
japokorn
force-pushed
the
master-fstab_to_blivet
branch
from
cf4ab09
to
59c7535
Compare
japokorn
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
| @@ -20,6 +20,7 @@ | |||
| import time | |||
|
|
|||
| from blivet import blockdev | |||
| from blivet.fstab import FSTabManager | |||
There was a problem hiding this comment.
Please also bump required version of blivet in spec to the version adding fstab support.
| self.assertTrue(test_dev in devices) | ||
|
|
||
| print("MYDEBUG: %s" % mounts) | ||
| print("MYDEBUG: %s" % devices) |
There was a problem hiding this comment.
This probably shouldn't be here :-)
|
Marking as blocked, because we'll need some changes in Blivet that are not yet released, see storaged-project/blivet#1263 |
japokorn
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
japokorn
force-pushed
the
master-fstab_to_blivet
branch
from
1ef59a0
to
98045a4
Compare
japokorn
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
- removed leftover debug messages from test_fsset.py - removed unused imports from fsset.py - changed variable's names to correct values in root.py - increased required blivet version in spec file
japokorn
force-pushed
the
master-fstab_to_blivet
branch
from
98045a4
to
8c30339
Compare
japokorn
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
This PR is stale because it has been open 60 days with no activity. |
|
@japokorn do you think you can find some time to finish the work here ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anaconda handling fstab is something that should be done by blivet. This moves the fstab logic into the blivet. Crypttab and blkidtab handling is not supported by blivet yet so it remains mostly unchanged (for now)
Added unit_tests