Skip to content

Commit

Permalink
infra: Retry failed test by default in kickstart test GH workflow
Browse files Browse the repository at this point in the history
More and more often we are running the whole kickstart test suite (or
big set of tests) on a PR, for example:

/kickstart-test --testtype network

/kickstart-test --skip-testtypes none

There is quite a big chance of hitting a flake, so retry failing tests
by default so there is no need to check if the failures are flakes or
re-run the failed tests manually.

The setting corresponds to the '--retry' launcher option.
  • Loading branch information
rvykydal committed Oct 16, 2024
1 parent 4683a89 commit b597a48
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/kickstart-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ jobs:
run: |
cat <<EOF > settings.ini
[kickstart_test]
retry_on_failure=True
kstest_local_repo=${{ github.workspace }}/kickstart-tests
[library]
directPath=${{ github.workspace }}/kickstart-tests/testlib
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/kickstart-tests.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ jobs:
run: |
cat <<EOF > settings.ini
[kickstart_test]
retry_on_failure=True
kstest_local_repo=${{ github.workspace }}/kickstart-tests
[library]
directPath=${{ github.workspace }}/kickstart-tests/testlib
Expand Down

0 comments on commit b597a48

Please sign in to comment.