tests: add UEFI boot tests for dual booting with ubuntu #512
Conversation
KKoukiou
force-pushed
the
test-efi
branch
3 times, most recently
from
8509a01
to
928b720
Compare
| @@ -67,6 +67,15 @@ class TestFedoraPlansUseFreeSpace(VirtInstallMachineCase): | |||
| with b.wait_timeout(300): | |||
| p.wait_done() | |||
|
|
|||
| # FIXME: https://bugzilla.redhat.com/show_bug.cgi?id=2325707 | |||
| # This should be removed from the test | |||
| if self.efi: | |||
There was a problem hiding this comment.
Where self.efi is initially defined in this base class?
| @@ -153,6 +166,12 @@ class TestFedoraPlansUseFreeSpace(VirtInstallMachineCase): | |||
| self.install(needs_confirmation=True) | |||
| self.verifyDualBoot(root_one_size=14.2, root_two_size=4.7) | |||
|
|
|||
| class TestFedoraPlansUseFreeSpaceBIOS(_TestFedoraPlansUseFreeSpace): | |||
| efi = False | |||
There was a problem hiding this comment.
If this should not be something like self.efi?
There was a problem hiding this comment.
Not sure what you ask
There was a problem hiding this comment.
Oh I guess you mean that I can instead setup it in the constructor with self.efi = False. Sure.
| @@ -44,7 +44,7 @@ class TestExistingSystemFedora(VirtInstallMachineCase): | |||
|
|
|||
| r.check_deleted_system("Fedora Linux") | |||
|
|
|||
| class TestFedoraPlansUseFreeSpace(VirtInstallMachineCase): | |||
| class _TestFedoraPlansUseFreeSpace(VirtInstallMachineCase): | |||
There was a problem hiding this comment.
I guess this is starting with _ to avoid the automated test discovery from picking it up, so it can work as a base class ? Still seems a little weird even if it is that case. :)
There was a problem hiding this comment.
Correct. I think the test discovery tool picks up everything starting with Test / test
I do use this pattern in some places more, see:
test/check-basic: def _testLogReview(self, b, m, idPrefix):
test/check-storage-mountpoints: def _testEncryptedUnlock(self, b, m):
I dont object that's weird, I can think of a new convention and change it also for the existing usages.
Sometihing like: CommonTestFedoraPlansUseFreeSpace
There was a problem hiding this comment.
Yeah, I think we should have something like that & have it documented somewhere as well. :) In any case, no need to block this PR on it. :)
No description provided.