Update fedora versions for CI workflows #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Jones <[email protected]>
Currently on the "update submodule" step, we're getting this: git submodule update --init --recursive fatal: detected dubious ownership in repository at '/__w/certwrapper/certwrapper' To add an exception for this directory, call: git config --global --add safe.directory /__w/certwrapper/certwrapper make: *** [Makefile:126: update] Error 128 Given the absolute lack of any details of what user the owner is and why that might be dubious, I've chosen to follow it's advice without prying too hard. Signed-off-by: Peter Jones <[email protected]>
vathpela
force-pushed
the
update-ci-distros
branch
from
00ffa92
to
0197449
Compare
Right now on some CI builds we get: aarch64-linux-gnu-gcc -nostdlib -fPIC -Wl,--warn-common -Wl,--no-undefined \ -Wl,--fatal-warnings -Wl,-shared -Wl,-Bsymbolic -L/usr/lib64 \ -L/__w/certwrapper/certwrapper/gnu-efi/ -Wl,--build-id=sha1 \ -Wl,--hash-style=sysv -o certmule.so certmule.o sbat_data.o \ /usr/lib/gcc/aarch64-linux-gnu/12/libgcc.a \ -T /__w/certwrapper/certwrapper/elf_aarch64_efi.lds /usr/bin/aarch64-linux-gnu-ld: warning: certmule.so has a LOAD segment with RWX permissions collect2: error: ld returned 1 exit status make: *** [../Makefile:115: certmule.so] Error 1 Right now this breaks CI despite no code change from when CI worked (due to the distros being updated). The segments themselves don't really matter (they exist in ELF but not in PE), so we could plausibly fix them, but that belongs in a different patch series. Unfortunately some of the linkers we're testing against don't support "--no-warn-rwx-segments", and some of them don't support "--no-error-rwx-segments". So for right now, I'm disabling "--fatal-warnings" instead. Signed-off-by: Peter Jones <[email protected]>
vathpela
force-pushed
the
update-ci-distros
branch
from
0197449
to
9ad0c5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the fedora versions in our CI workflows.