add entropy functions #309
Conversation
There was a problem hiding this comment.
Thanks Mar for the PR!
I have some change requests and I would also ask you to add yourself as a contributor to the DESCRIPTION (similar to https://github.com/rformassspectrometry/MsCoreUtils/blob/main/DESCRIPTION), to also increase the version in DESCRIPTION to 1.13.4 and to also add an entry to the NEWS file mentioning that you added the entropy method.
R/Spectra.R
Outdated
| #' | ||
| #' @importFrom MsCoreUtils entropy | ||
| setMethod("entropy", "Spectra", function(object, normalized = TRUE) { | ||
| if (length(object)) |
There was a problem hiding this comment.
for normalize == TRUE we would need to call nentropy, for normalized = FALSE entropy - I would suggest to add something like:
if (normalized) entropy_fun <- nentropy
else entropy_fun <- entropy
unlist(.peaksapply(
object, FUN = function(pks, ...) entropy_fun(pks[, "intensity"])),
use.names = FALSE
))ah, and please remove the na.rm = TRUE since the entropy function does not support that.
R/Spectra.R
Outdated
|
|
||
| #' @rdname Spectra | ||
| #' | ||
| #' @importFrom MsCoreUtils entropy |
There was a problem hiding this comment.
here import both, entropy and nentropy
|
Thanks Mar @mar-garcia for this contribution! I'll merge and fix the missing NAMESPACE entry. |
@jorainer, I've tried to follow your suggestions...
Not sure if I've understood everything 100%, but let's try to star with what I've done here :)
Let me know if I should proceed in another way, change anything, etc..
Thanks!!