Support smooth scrolling #640
Conversation
|
Awesome! Great to see this making its way in - thanks @szbergeron ! |
|
Depends on changes in revery-ui/esy-sdl2#6, revery-ui/reason-sdl2#25
Thanks, happy to help 😃 |
src/Core/Window.re
Outdated
| | _ => | ||
| log("Unknown event recieved"); | ||
| () |
src/Core/Window.re
Outdated
| let wheelEvent: Events.mouseWheelEvent = { | ||
| deltaX: float_of_int(deltaX), | ||
| deltaY: float_of_int(deltaY), | ||
| }; | ||
| Event.dispatch(v.onMouseWheel, wheelEvent); | ||
| | Sdl2.Event.MousePan({deltaX, deltaY, _}) => | ||
| log("====Pan of " ++ string_of_int(deltaX) ++ ", " ++ string_of_int(deltaY)); |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 640 in repo revery-ui/revery |
|
@bryphe is running CI intended to be a privileged action? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Bunch of funky stuff seems to be going on with CI for this |
|
Hygiene check fails because of formatting. Run |
|
Running |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 640 in repo revery-ui/revery |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Might be different version, but it's also not completely stable I've found. |
|
This includes a lot of unrelated changes, which makes it really hard to review. Do you think you could try a rebase? |
|
Oh whoops, figured it would reconcile. I can try rebasing but not sure if that would help. |
|
Might make more sense to just revert the top two commits and remake them |
|
An interactive rebase allows you to do pretty much that. |
|
I seem to have gotten myself in a bit of a pickle trying to do it with rebasing, lots of conflicts and none of them make much sense 🤷♀️ |
|
That happens sometimes. Just The way I think about a rebase is that it replays a set of commits onto the HEAD of the branch or ref you specify. Typically the set set of commits is every commit in your branch from the most recent common ancestor, but you can select the commits yourself by doing an interactive rebase with When you run Hope that helps! If not, let me know and I'll try to guide you as best I can. |
szbergeron
force-pushed
the
master
branch
2 times, most recently
from
871ed26
to
bfa2a2d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Looks much better! Didn't realize the change was this tiny though. It really would have been much easier to just copy the changes out and back in after resetting. But hopefully you learned something new! |
|
Something's up with the Linux CI: |
|
@bryphe I'm currently a bit occupied with projects other than libscroll atm, but since scrolling on wayland is currently regressed by the esy-sdl2/reason-sdl2 changes being applied without this one it's probably a good idea to at least wrap up this part so it isn't up in the air. Would you be able to kick the CI to see if that issue was just a transient issue? I don't currently see why it failed (I think the build logs expired maybe?) |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I think this is obsolete now and is anyway superseded by libscroll integration, so closing while I can get libscroll patch at #766 working. |
Adds a stub to allow directly pulling smooth scroll events from reason-sdl2