[feat] Disable pyright checking field Pydantic field aliases #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…generated clients
blast-hardcheese
requested review from
jackyzha0
and removed request for
a team
ryantm
approved these changes
Oct 25, 2024
blast-hardcheese
deleted the
dstewart/feat/pyright-ignore-field-aliases
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If we ignore the alias field, we can use pyright to typecheck python generated clients.
What changed
Reflow the field assignment to permit ignoring type aliases like
alias="$kind"Test plan
Manually ran against production services, typechecked OK