feat/python module composition #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
force-pushed
the
dstewart/feat/python-module-composition
branch
3 times, most recently
from
a096fea
to
0f5e5d3
Compare
blast-hardcheese
requested review from
vlinkz
and removed request for
a team
vlinkz
approved these changes
Sep 21, 2024
blast-hardcheese
force-pushed
the
dstewart/feat/python-module-composition
branch
from
0f5e5d3
to
0cad6fc
Compare
blast-hardcheese
requested review from
airportyh
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It's currently very challenging to iterate on python modules, as well as testing replacing
pyright-extendedwith pyright+ruff. In support of that, let's just describe these as different modules.These modules are not intended to be used directly, instead they will be toggled on/off via feature flag during env building in pid1.
What changed
python-base-*,ruff, andpyrightmodulesTest plan
Compose these modules together and test the workspace. Ensure package installs are detected by pyright/ruff.
Rollout