feat: fetch VTT or SRT subtitles if only a transcript URL is provided #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
force-pushed
the
feat/fetch-subtitles
branch
from
0aa83ae
to
cb67ec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a feature to fetch subtitles if a
Transcripthas asubtitleUrlbut notext. If this is the case, thesubtitleUrlis fetched and parsed as either SRT or VTT. The parsed subtitles are concatenated without time markers and inserted into thetextfield of the transcript.This PR includes both the implementation and a test.
Because #102 is still not merged unfortunately, this PR is based on #104 which builds upon the
translationsbranch and adds recent changes frommain.Because tests are still broken in #102 and #104 this PR is also not green. The new test passes though.