Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: defer iframe load #3219

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: defer iframe load #3219

wants to merge 10 commits into from

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Nov 8, 2024

Description

  • Updates secure site url to include version parameter as `2.0.0``
  • Defers frame injection into the DOM until needed in email/social connection flow.
  • Defers resolution of frameLoadPromise to when receiving FRAME_READY event from the frame to more accurately unblock other requests to the iframe until ready, given iframe.onload did not consider the extra time required to initialize the SDK inside of the page itself.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-779

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Nov 8, 2024

Copy link

changeset-bot bot commented Nov 8, 2024

🦋 Changeset detected

Latest commit: 58bbdd7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@apps/laboratory Patch
@reown/appkit-wallet Patch
@apps/demo Patch
@apps/gallery Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 9:53am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 9:53am
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 9:53am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 9:53am
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 9:53am
web3modal-gallery ✅ Ready (Inspect) Visit Preview Nov 11, 2024 9:53am

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 340.18999999999994% 4512 / 19108
🔵 Statements 340.18999999999994% 4512 / 19108
🔵 Functions 375.96000000000004% 372 / 1097
🔵 Branches 465.5% 683 / 1397
File CoverageNo changed files found.
Generated in workflow #7314 for commit 58bbdd7 by the Vitest Coverage Report Action

packages/wallet/src/W3mFrame.ts Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Warnings
⚠️ Secure site URL has been changed

Generated by 🚫 dangerJS against 58bbdd7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants