Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #452 installed binary path check on Windows git bash #453

Conversation

elliotwutingfeng
Copy link
Contributor

@elliotwutingfeng elliotwutingfeng commented Oct 6, 2024

Closes #452

When installing on Windows via git bash, command -v mob gives a UNIX style path while $target gives a UNIX style path but with a Windows style drive lettering (e.g. "C:/..."), leading to a mismatch.

This patch checks if the system is Windows, and if so, converts the expected path to the same format (Windows style drive lettering, forward slashes) before comparison.

Copy link
Collaborator

@gregorriegler gregorriegler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for looking into this issue.
Unfortunately the proposed solution only works if cygwin is installed. We need this to work regardless.

See https://chatgpt.com/share/6702329e-a264-800f-a7cb-706fccee0716

@elliotwutingfeng elliotwutingfeng marked this pull request as draft October 6, 2024 07:29
@elliotwutingfeng
Copy link
Contributor Author

Current iteration requires sed. MINGW64 does not include any string manipulation tools by default. However, install.sh assumes that curl, grep, cut and tr are available, so there is a good chance sed would be available as well.

@elliotwutingfeng elliotwutingfeng marked this pull request as ready for review October 6, 2024 10:03
@gregorriegler gregorriegler merged commit 09ee97d into remotemobprogramming:main Oct 6, 2024
5 of 6 checks passed
@elliotwutingfeng elliotwutingfeng deleted the windows_binary_path_check branch October 7, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test if installation is successful fails
2 participants