Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#406 - removed cancelation of mob timers #407

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

hollesse
Copy link
Member

This MR closes #406

@hollesse hollesse added the enhancement New feature or request label Jan 25, 2024
Copy link
Collaborator

@gregorriegler gregorriegler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is definitely something we should try quickly to get rid of the malware detection.
Since its behaving differently with the timer now, we should at least change the minor version, no?

@gregorriegler
Copy link
Collaborator

changed version. feel free to merge

@hollesse
Copy link
Member Author

I agree it should be a minor version change. But then the Version should be 4.5.0 correct?

@gregorriegler
Copy link
Collaborator

of course 😃

@gregorriegler gregorriegler merged commit c005061 into main Feb 1, 2024
12 checks passed
@hollesse hollesse deleted the 406-remove-timer-cancellation branch April 26, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove cancellation of the local mob timer when doing mob done or mob next
2 participants