IdeaBiz SMS Gateway Intergration #190
Conversation
|
@ravithb good stuff. A couple of questions, is it possible to pull in the Ideabiz SMS classes trough composer without polluting the global app namespace? Worst case publish and pull in your own package. And move the business logic that is relevant to the app to the app src. |
|
@gayan thanks. I'll check and get the idea biz classes through composer.
Its the first time I'm working on laravel and composer, so its good that
you pointed it out. :)
…On 7 June 2017 at 19:15, Gayan ***@***.***> wrote:
@ravithb <https://github.com/ravithb> good stuff. A couple of questions,
is it possible to pull in the Ideabiz SMS classes trough composer without
polluting the global app namespace? Worst case publish and pull in your own
package. And move the business logic that is relevant to the app to the app
src.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/reliefsupports/reliefsupports.org/pull/190#issuecomment-306799401>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGcJgFzz1dmVjFeyUGv38DeZI57V3moqks5sBqmNgaJpZM4NyhDc>
.
|
|
@ravithb are you working on those changes as @gayanhewa mentioned? Should we keep the PR without merging until you finish those or? Plus, |
|
@thinkholic Yes, I'll work on those today, we can keep the PR open till those are done. You are right, the base should be dev. |
|
@gayanhewa @thinkholic please review commits 3a5f8bd and ffa0c51. Thanks. |
|
@ravithb stash the commits to one. Can you also add a link to the ideabiz package repo |
Fixing issue in coposer.json
Fixing issue in coposer.json
|
I had to restructure the original ideabiz code. https://github.com/ravithb/IdeaBiz-Request-Handler---PHP |
|
@gayanhewa pls see 53df6c1 |
There was a problem hiding this comment.
@thinkholic @ravithb this is ok to merge. @ravithb we can do a couple of improvements outside this PR to restructure the code better. ping me on Gitter I will explain. But for now this is alright.
|
@ravithb @gayanhewa Will take this tonight. |
|
@thinkholic |
What you've done
...
Creating an endpoint (POST /sms/receive) to receive sms in the format documented in http://docs.ideabiz.lk/APIs/SMS
Why have you done it
...
As a partial fix for issue https://github.com/reliefsupports/reliefsupports.org/issues/8
Any testing carried out
...
Manual testing was carried out.