Added search feature on Donations and Needs page #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gayanhewa
reviewed
Jun 5, 2017
| @@ -81,7 +81,7 @@ public function searchDonations($search){ | |||
| $query = $query->where(DB::Raw('CONCAT_WS(" ",name,telephone,address,city,donation,information) '),"like","%$searchPart%"); | |||
| } | |||
| } | |||
| return $query->get(); | |||
| return $query->orderBy('id', 'desc')->paginate(\Config::get('rf_settings.donations_page_pagination')); | |||
There was a problem hiding this comment.
\Config::get can be replaced with config() calls
gayanhewa
suggested changes
Jun 5, 2017
| @@ -83,7 +83,7 @@ public function searchNeeds($search){ | |||
| $query = $query->where(DB::Raw('CONCAT_WS(" ",name,telephone,address,city,needs)'),"like","%$searchPart%"); | |||
There was a problem hiding this comment.
This query might be open to SQL injection. Since the calls to searchNeeds with the parameter is passed to a DB::raw which doesn't use prepared statements nor sanitises the input.
There was a problem hiding this comment.
@nadeeravista could you please have a look on @gayanhewa's comment as well as fix conflicts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What you've done
Added search feature on donations and needs page.
Also created a settings file which we can use to store application related settings such as pagination etc.
Why have you done it
Screenshot (if visual)
...
Any testing carried out
Locally tested with English and Sinhala