Recognize byte slice for key argument in cluster client hash slot computation #3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LINKIWI
changed the title
|
It seems that you have restricted modifications to your PR code. You can either open the permissions or resolve the conflicts yourself. |
LINKIWI
force-pushed
the
command-key-heuristic-bytes
branch
from
e1f8ca8
to
7e90536
Compare
Done! Rebased and conflicts resolved |
monkey92t
approved these changes
Jul 16, 2024
|
@ofekshenawa merge? |
|
Is it possible to merge this? This PR fixes a pretty significant performance bug for us. Thanks! |
ofekshenawa
approved these changes
Jul 23, 2024
LINKIWI
force-pushed
the
command-key-heuristic-bytes
branch
from
35ae45e
to
3cd7c33
Compare
|
@ofekshenawa I rebased this branch and the build is now green. Are we good to merge? Thanks. |
|
@vladvildanov @ofekshenawa Are you able to help with this merge? We have been running this patch in production for several months and have confirmed that it fixes the issue in the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mildly related to #3048.
The cluster client uses the command type to determine the expected key position in the command arguments slice to compute the hash slot. This enables the client to properly send the command to the node that owns that slot, according to the cached cluster topology state.
For generic commands assembled with the
Do()API, the logic falls back to assuming the key is at position 1. Though this is a reasonable assumption, it depends on the argument to be ofstringtype;[]bytetype arguments are not converted to strings, which results in an incorrect slot computation, thus forcing (in most cases) a double round trip caused by response to aMOVEDredirection.This PR adds a
[]bytetype case for key string serialization, so that the generic commands passed as byte slices yield the correct cluster hash slot.