Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ring: Support shard discovery using periodic SRV lookups #2677

Closed
wants to merge 7 commits into from
Closed

ring: Support shard discovery using periodic SRV lookups #2677

wants to merge 7 commits into from

Conversation

beautifulentropy
Copy link

No description provided.

@beautifulentropy beautifulentropy marked this pull request as ready for review August 17, 2023 19:34
@beautifulentropy
Copy link
Author

Go / build (1.20.x) failure appears to be a flake:

• [FAILED] [0.001 seconds]
Commands [BeforeEach] SlowLogGet returns slow query result
  [BeforeEach] /home/runner/work/go-redis/go-redis/commands_test.go:31
  [It] /home/runner/work/go-redis/go-redis/commands_test.go:6881

  [FAILED] Unexpected error:
      <proto.RedisError>: BUSY Redis is busy running a script. You can only call FUNCTION KILL or SHUTDOWN NOSAVE.
      BUSY Redis is busy running a script. You can only call FUNCTION KILL or SHUTDOWN NOSAVE.
  occurred
  In [BeforeEach] at: /home/runner/work/go-redis/go-redis/commands_test.go:33 @ 08/17/23 18:03:16.249

@beautifulentropy
Copy link
Author

beautifulentropy commented Aug 30, 2023 •
edited
Loading

No need to merge this. Folks can and should use .SetAddrs() in v9 with their own service discovery mechanism of choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@beautifulentropy